Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document generate for toolchains and deprecate toolchain and write_toolchain_files #1940

Merged
merged 8 commits into from Dec 2, 2020
Merged

Document generate for toolchains and deprecate toolchain and write_toolchain_files #1940

merged 8 commits into from Dec 2, 2020

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Dec 1, 2020 •
edited

@czoido czoido mentioned this pull request Dec 1, 2020
Merged
@czoido czoido added this to the 1.32 milestone Dec 1, 2020
@czoido czoido mentioned this pull request Dec 1, 2020
Merged
jgsogo
jgsogo suggested changes Dec 2, 2020
View reviewed changes
creating_packages/toolchains.rst Outdated Show resolved Hide resolved
creating_packages/toolchains.rst Outdated Show resolved Hide resolved
creating_packages/toolchains.rst Outdated Show resolved Hide resolved
creating_packages/toolchains.rst Outdated Show resolved Hide resolved
creating_packages/toolchains/cmake.rst Outdated Show resolved Hide resolved
creating_packages/toolchains/make.rst Outdated Show resolved Hide resolved
creating_packages/toolchains/msbuild.rst Outdated Show resolved Hide resolved
czoido and others added 5 commits December 2, 2020 13:33
@czoido
revisions
e2b950c
@czoido @jgsogo
Update creating_packages/toolchains.rst
12f92db 
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
@czoido @jgsogo
Update creating_packages/toolchains.rst
a71226d 
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
@czoido @jgsogo
Update creating_packages/toolchains.rst
26a9e32 
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
@czoido
revision
3a36b51
@czoido czoido requested a review from jgsogo December 2, 2020 12:46
jgsogo
jgsogo approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and we will remove those warnings in 1.33

@jgsogo jgsogo merged commit cf922b7 into conan-io:develop Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo approved these changes

@memsharded memsharded memsharded approved these changes

Assignees

@jgsogo jgsogo

Labels
None yet
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@czoido @jgsogo @memsharded